Repository navigation
docs: say what moneta's specification settles, and read a balance dated without a time - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9
MONETA's specification (`VipAISPPayments_v4` 1.0.1, from the developer portal) confirms most of what the live tests found and settles a few open questions: no movement has a time of day, the partner headers are optional, the date range filters on `valueDate`, a page can exceed `size` with pending movements, and a 429 exists but with no limit and no `Retry-After`. The docs now say so, and the portal's own guides add that a partner without a PSD2 licence gets a sandbox only: production is always the merchant's token.
One code change: the specification calls a balance's `dateTime` "date or date and time". Live it has always been an instant, but a bare date would have failed the parse; it now reads as the start of that day in Prague, and anything else unreadable is an `InvalidResponse`.
The specification itself is not committed. The portal's terms do not say it may be republished, so `spec/` is ignored by git, a place to keep downloads beside the code.
Live responses also carry `bankTransactionCode` and `creditLine`, which the specification does not list; noted in moneta-api.md.